refactor: quality gradle plugins#11046
Merged
wmontwe merged 4 commits intoJun 4, 2026
Merged
Conversation
github-actions
Bot
added
the
tb-team
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
wmontwe
added
the
report: exclude
wmontwe
changed the title
dani-zilla
previously approved these changes
Jun 1, 2026
# Conflicts: # feature/thundermail/internal/common/src/main/kotlin/net/thunderbird/feature/thundermail/internal/common/navigation/DefaultThundermailNavigation.kt
wmontwe
force-pushed
the
refactor-quality-gradle-plugins
branch
from
ebb378b to
5931dcb
Compare
rafaeltonholo
approved these changes
Jun 4, 2026
rafaeltonholo
left a comment
rafaeltonholo
left a comment
Member
There was a problem hiding this comment.
LGTM. Just a nit: I would rather prefer instead of suppressing the detekt issues having them in the baseline, but not a blocker for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new custom Gradle plugins for code quality: one for Detekt (static code analysis) and one for Spotless (code formatting). It migrates all modules to use these new plugins instead of the previous script-based approach. Additionally, applies format updates and fixes some of the
detektAllfindings.This harmonizes the project setup with Thunderbird Mobile Components